Commit 296aa266 authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: VMX: Pass desired vector instead of bool for triggering posted IRQ 



Refactor the posted interrupt helper to take the desired notification
vector instead of a bool so that the callers are self-documenting.

No functional change intended.

Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Reviewed-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
Message-Id: <20211208015236.1616697-19-seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 0f65a9d3

arch/x86/kvm/vmx/vmx.c

+3 −5
Original line number Diff line number Diff line
@@ -3932,11 +3932,9 @@ static void vmx_msr_filter_changed(struct kvm_vcpu *vcpu) 
}



static inline bool kvm_vcpu_trigger_posted_interrupt(struct kvm_vcpu *vcpu,

						     bool nested)

						     int pi_vec)

{

#ifdef CONFIG_SMP

	int pi_vec = nested ? POSTED_INTR_NESTED_VECTOR : POSTED_INTR_VECTOR;



	if (vcpu->mode == IN_GUEST_MODE) {

		/*

		 * The vector of interrupt to be delivered to vcpu had
@@ -3997,7 +3995,7 @@ static int vmx_deliver_nested_posted_interrupt(struct kvm_vcpu *vcpu, 
		smp_mb__after_atomic();



		/* the PIR and ON have been set by L1. */

		if (!kvm_vcpu_trigger_posted_interrupt(vcpu, true))

		if (!kvm_vcpu_trigger_posted_interrupt(vcpu, POSTED_INTR_NESTED_VECTOR))

			kvm_vcpu_wake_up(vcpu);

		return 0;

	}
@@ -4035,7 +4033,7 @@ static int vmx_deliver_posted_interrupt(struct kvm_vcpu *vcpu, int vector) 
	 * guaranteed to see PID.ON=1 and sync the PIR to IRR if triggering a

	 * posted interrupt "fails" because vcpu->mode != IN_GUEST_MODE.

	 */

	if (!kvm_vcpu_trigger_posted_interrupt(vcpu, false))

	if (!kvm_vcpu_trigger_posted_interrupt(vcpu, POSTED_INTR_VECTOR))

		kvm_vcpu_wake_up(vcpu);



	return 0;