Unverified Commit 29681184 authored by Li Zetao's avatar Li Zetao Committed by Mark Brown
Browse files

ASoC: SOF: ipc3: Use devm_kmemdup to replace devm_kmalloc + memcpy 



Use the helper function devm_kmemdup() rather than duplicating its
implementation, which helps to enhance code readability.

Signed-off-by: default avatarLi Zetao <lizetao1@huawei.com>
Reviewed-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/r/20230810114738.2103792-3-lizetao1@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b0a4c7f5

sound/soc/sof/ipc3.c

+1 −4
Original line number Diff line number Diff line
@@ -567,13 +567,10 @@ int sof_ipc3_get_cc_info(struct snd_sof_dev *sdev, 
	/* create read-only cc_version debugfs to store compiler version info */

	/* use local copy of the cc_version to prevent data corruption */

	if (sdev->first_boot) {

		sdev->cc_version = devm_kmalloc(sdev->dev, cc->ext_hdr.hdr.size,

						GFP_KERNEL);



		sdev->cc_version = devm_kmemdup(sdev->dev, cc, cc->ext_hdr.hdr.size, GFP_KERNEL);

		if (!sdev->cc_version)

			return -ENOMEM;



		memcpy(sdev->cc_version, cc, cc->ext_hdr.hdr.size);

		ret = snd_sof_debugfs_buf_item(sdev, sdev->cc_version,

					       cc->ext_hdr.hdr.size,

					       "cc_version", 0444);