Commit 29573083 authored by Chengming Zhou's avatar Chengming Zhou Committed by Petr Mladek
Browse files

livepatch: Don't block removal of patches that are safe to unload 



module_put() is not called for a patch with "forced" flag. It should
block the removal of the livepatch module when the code might still
be in use after forced transition.

klp_force_transition() currently sets "forced" flag for all patches on
the list.

In fact, any patch can be safely unloaded when it passed through
the consistency model in KLP_UNPATCHED transition.

In other words, the "forced" flag must be set only for livepatches
that are being removed. In particular, set the "forced" flag:

  + only for klp_transition_patch when the transition to KLP_UNPATCHED
    state was forced.

  + all replaced patches when the transition to KLP_PATCHED state was
    forced and the patch was replacing the existing patches.

Signed-off-by: default avatarChengming Zhou <zhouchengming@bytedance.com>
Acked-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Tested-by: default avatarPetr Mladek <pmladek@suse.com>
[mbenes@suse.cz: wording improvements]
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220312152220.88127-1-zhouchengming@bytedance.com
parent 77dbd72b

kernel/livepatch/transition.c

+9 −2
Original line number Diff line number Diff line
@@ -641,6 +641,13 @@ void klp_force_transition(void) 
	for_each_possible_cpu(cpu)

		klp_update_patch_state(idle_task(cpu));



	klp_for_each_patch(patch)

	/* Set forced flag for patches being removed. */

	if (klp_target_state == KLP_UNPATCHED)

		klp_transition_patch->forced = true;

	else if (klp_transition_patch->replace) {

		klp_for_each_patch(patch) {

			if (patch != klp_transition_patch)

				patch->forced = true;

		}

	}

}