Commit 29499ab0 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

bcache: don't pass a stack address to blkdev_get_by_path 



sb is just an on-stack pointer that can easily be reused by other calls.
Switch to use the bcache-wide bcache_kobj instead as there is no need to
claim per-bcache device anyway.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20230608110258.189493-13-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent c889d079

drivers/md/bcache/super.c

+1 −1
Original line number Diff line number Diff line
@@ -2560,7 +2560,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, 
	err = "failed to open device";

	bdev = blkdev_get_by_path(strim(path),

				  FMODE_READ|FMODE_WRITE|FMODE_EXCL,

				  sb, NULL);

				  bcache_kobj, NULL);

	if (IS_ERR(bdev)) {

		if (bdev == ERR_PTR(-EBUSY)) {

			dev_t dev;