Commit 292f750f authored Feb 17, 2021 by Colin Ian King Committed by Greg Kroah-Hartman Mar 10, 2021

USB: gadget: dummy-hcd: remove redundant initialization of variable 'value'



The variable 'value' is being initialized with 1 that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210217210124.197780-1-colin.king@canonical.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9c174b57

drivers/usb/gadget/udc/dummy_hcd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1866,7 +1866,7 @@ static void dummy_timer(struct timer_list *t)
		/* handle control requests */
		if (ep == &dum->ep[0] && ep->setup_stage) {
		struct usb_ctrlrequest setup;
		int value = 1;
		int value;

		setup = (struct usb_ctrlrequest ) urb->setup_packet;
		/* paranoia, in case of stale queued data */