Commit 292bff94 authored by Colin Ian King's avatar Colin Ian King Committed by Kalle Valo
Browse files

ath11k: add missing null check on allocated skb 



Currently the null check on a newly allocated skb is missing and
this can lead to a null pointer dereference is the allocation fails.
Fix this by adding a null check and returning -ENOMEM.

Addresses-Coverity: ("Dereference null return")
Fixes: 43ed15e1 ("ath11k: put hw to DBS using WMI_PDEV_SET_HW_MODE_CMDID")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201214232417.84556-1-colin.king@canonical.com
parent 13458ffe

drivers/net/wireless/ath/ath11k/wmi.c

+3 −0
Original line number Diff line number Diff line
@@ -3460,6 +3460,9 @@ int ath11k_wmi_set_hw_mode(struct ath11k_base *ab, 
	len = sizeof(*cmd);



	skb = ath11k_wmi_alloc_skb(wmi_ab, len);

	if (!skb)

		return -ENOMEM;



	cmd = (struct wmi_pdev_set_hw_mode_cmd_param *)skb->data;



	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_PDEV_SET_HW_MODE_CMD) |