Commit 2929cceb authored by Wei Yongjun's avatar Wei Yongjun Committed by Jakub Kicinski
Browse files

net/x25: Fix skb leak in x25_lapb_receive_frame() 



x25_lapb_receive_frame() using skb_copy() to get a private copy of
skb, the new skb should be freed in the undersized/fragmented skb
error handling path. Otherwise there is a memory leak.

Fixes: cb101ed2 ("x25: Handle undersized/fragmented skbs")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarMartin Schiller <ms@dev.tdt.de>
Link: https://lore.kernel.org/r/20221114110519.514538-1-weiyongjun@huaweicloud.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c9b895c6

net/x25/x25_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ int x25_lapb_receive_frame(struct sk_buff *skb, struct net_device *dev, 


	if (!pskb_may_pull(skb, 1)) {

		x25_neigh_put(nb);

		return 0;

		goto drop;

	}



	switch (skb->data[0]) {