Commit 2920417c authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Jens Axboe
Browse files

mtip32xx: remove pointless drvdata checking 



The .suspend() and .resume() methods are only called after the .probe()
method (mtip_pci_probe()) has set the drvdata and returned success.

Therefore, if we get to mtip_pci_suspend() or mtip_pci_resume(), the
drvdata must be valid.  Drop the unnecessary checking.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20211208192449.146076-2-helgaas@kernel.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 52a0cab3

drivers/block/mtip32xx/mtip32xx.c

+1 −14
Original line number Diff line number Diff line
@@ -4150,12 +4150,6 @@ static int mtip_pci_suspend(struct pci_dev *pdev, pm_message_t mesg) 
	int rv = 0;

	struct driver_data *dd = pci_get_drvdata(pdev);



	if (!dd) {

		dev_err(&pdev->dev,

			"Driver private datastructure is NULL\n");

		return -EFAULT;

	}



	set_bit(MTIP_DDF_RESUME_BIT, &dd->dd_flag);



	/* Disable ports & interrupts then send standby immediate */
@@ -4189,14 +4183,7 @@ static int mtip_pci_suspend(struct pci_dev *pdev, pm_message_t mesg) 
static int mtip_pci_resume(struct pci_dev *pdev)

{

	int rv = 0;

	struct driver_data *dd;



	dd = pci_get_drvdata(pdev);

	if (!dd) {

		dev_err(&pdev->dev,

			"Driver private datastructure is NULL\n");

		return -EFAULT;

	}

	struct driver_data *dd = pci_get_drvdata(pdev);



	/* Move the device to active State */

	pci_set_power_state(pdev, PCI_D0);