Commit 2910a4a9 authored by Randy Dunlap's avatar Randy Dunlap Committed by Martin K. Petersen
Browse files

scsi: mpt3sas: Documentation cleanup 

Fix kernel-doc warnings, spellos, and typos.

drivers/scsi/mpt3sas/mpt3sas_base.c:5430: warning: Excess function parameter 'ct' description in '_base_allocate_pcie_sgl_pool'
drivers/scsi/mpt3sas/mpt3sas_base.c:5493: warning: Excess function parameter 'ctr' description in '_base_allocate_chain_dma_pool'
mpt3sas_base.c:1362: warning: missing initial short description on line:
 * _base_display_reply_info -
mpt3sas_base.c:2151: warning: contents before sections
mpt3sas_base.c:2314: warning: missing initial short description on line:
 * base_make_prp_nvme -

Link: https://lore.kernel.org/r/20210418203246.782-1-rdunlap@infradead.org


Cc: linux-scsi@vger.kernel.org
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: MPT-FusionLinux.pdl@broadcom.com
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6235bef6

drivers/scsi/mpt3sas/mpt3sas_base.c

+50 −49
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ _base_clear_outstanding_commands(struct MPT3SAS_ADAPTER *ioc); 
 * @mpi_request:mf request pointer.

 * @sz:		size of buffer.

 *

 * @Returns - 1/0 Reset to be done or Not

 * Return: 1/0 Reset to be done or Not

 */

u8

mpt3sas_base_check_cmd_timeout(struct MPT3SAS_ADAPTER *ioc,
@@ -440,7 +440,7 @@ static void _clone_sg_entries(struct MPT3SAS_ADAPTER *ioc, 
		return;



	/* From smid we can get scsi_cmd, once we have sg_scmd,

	 * we just need to get sg_virt and sg_next to get virual

	 * we just need to get sg_virt and sg_next to get virtual

	 * address associated with sgel->Address.

	 */
@@ -600,7 +600,7 @@ static int mpt3sas_remove_dead_ioc_func(void *arg) 
 * _base_sync_drv_fw_timestamp - Sync Drive-Fw TimeStamp.

 * @ioc: Per Adapter Object

 *

 * Return nothing.

 * Return: nothing.

 */

static void _base_sync_drv_fw_timestamp(struct MPT3SAS_ADAPTER *ioc)

{
@@ -704,7 +704,7 @@ _base_fault_reset_work(struct work_struct *work) 


		/*

		 * Call _scsih_flush_pending_cmds callback so that we flush all

		 * pending commands back to OS. This call is required to aovid

		 * pending commands back to OS. This call is required to avoid

		 * deadlock at block layer. Dead IOC will fail to do diag reset,

		 * and this call is safe since dead ioc will never return any

		 * command back from HW.
@@ -873,7 +873,7 @@ mpt3sas_base_fault_info(struct MPT3SAS_ADAPTER *ioc , u16 fault_code) 
 * @ioc: per adapter object

 * @fault_code: fault code

 *

 * Return nothing.

 * Return: nothing.

 */

void

mpt3sas_base_coredump_info(struct MPT3SAS_ADAPTER *ioc, u16 fault_code)
@@ -887,7 +887,7 @@ mpt3sas_base_coredump_info(struct MPT3SAS_ADAPTER *ioc, u16 fault_code) 
 * @ioc: per adapter object

 * @caller: caller function name

 *

 * Returns 0 for success, non-zero for failure.

 * Return: 0 for success, non-zero for failure.

 */

int

mpt3sas_base_wait_for_coredump_completion(struct MPT3SAS_ADAPTER *ioc,
@@ -1359,7 +1359,7 @@ _base_sas_log_info(struct MPT3SAS_ADAPTER *ioc , u32 log_info) 
}



/**

 * _base_display_reply_info -

 * _base_display_reply_info - handle reply descriptors depending on IOC Status

 * @ioc: per adapter object

 * @smid: system request message index

 * @msix_index: MSIX table index supplied by the OS
@@ -1804,7 +1804,7 @@ _base_interrupt(int irq, void *bus_id) 
 * @irqpoll: irq_poll object

 * @budget: irq poll weight

 *

 * returns number of reply descriptors processed

 * Return: number of reply descriptors processed

 */

static int

_base_irqpoll(struct irq_poll *irqpoll, int budget)
@@ -1826,7 +1826,7 @@ _base_irqpoll(struct irq_poll *irqpoll, int budget) 
		enable_irq(reply_q->os_irq);

		/*

		 * Go for one more round of processing the

		 * reply descriptor post queue incase if HBA

		 * reply descriptor post queue in case the HBA

		 * Firmware has posted some reply descriptors

		 * while reenabling the IRQ.

		 */
@@ -1840,7 +1840,7 @@ _base_irqpoll(struct irq_poll *irqpoll, int budget) 
 * _base_init_irqpolls - initliaze IRQ polls

 * @ioc: per adapter object

 *

 * returns nothing

 * Return: nothing

 */

static void

_base_init_irqpolls(struct MPT3SAS_ADAPTER *ioc)
@@ -1878,7 +1878,7 @@ _base_is_controller_msix_enabled(struct MPT3SAS_ADAPTER *ioc) 
 * @ioc: per adapter object

 * @poll: poll over reply descriptor pools incase interrupt for

 *		timed-out SCSI command got delayed

 * Context: non ISR conext

 * Context: non-ISR context

 *

 * Called when a Task Management request has completed.

 */
@@ -2104,7 +2104,16 @@ _base_build_sg(struct MPT3SAS_ADAPTER *ioc, void *psge, 


/**

 * _base_build_nvme_prp - This function is called for NVMe end devices to build

 * a native SGL (NVMe PRP). The native SGL is built starting in the first PRP

 *                        a native SGL (NVMe PRP).

 * @ioc: per adapter object

 * @smid: system request message index for getting asscociated SGL

 * @nvme_encap_request: the NVMe request msg frame pointer

 * @data_out_dma: physical address for WRITES

 * @data_out_sz: data xfer size for WRITES

 * @data_in_dma: physical address for READS

 * @data_in_sz: data xfer size for READS

 *

 * The native SGL is built starting in the first PRP

 * entry of the NVMe message (PRP1).  If the data buffer is small enough to be

 * described entirely using PRP1, then PRP2 is not used.  If needed, PRP2 is

 * used to describe a larger data buffer.  If the data buffer is too large to
@@ -2133,7 +2142,7 @@ _base_build_sg(struct MPT3SAS_ADAPTER *ioc, void *psge, 
 * Each 64-bit PRP entry comprises an address and an offset field.  The address

 * always points at the beginning of a 4KB physical memory page, and the offset

 * describes where within that 4KB page the memory segment begins.  Only the

 * first element in a PRP list may contain a non-zero offest, implying that all

 * first element in a PRP list may contain a non-zero offset, implying that all

 * memory segments following the first begin at the start of a 4KB page.

 *

 * Each PRP element normally describes 4KB of physical memory, with exceptions
@@ -2147,14 +2156,6 @@ _base_build_sg(struct MPT3SAS_ADAPTER *ioc, void *psge, 
 * Since PRP entries lack any indication of size, the overall data buffer length

 * is used to determine where the end of the data memory buffer is located, and

 * how many PRP entries are required to describe it.

 *

 * @ioc: per adapter object

 * @smid: system request message index for getting asscociated SGL

 * @nvme_encap_request: the NVMe request msg frame pointer

 * @data_out_dma: physical address for WRITES

 * @data_out_sz: data xfer size for WRITES

 * @data_in_dma: physical address for READS

 * @data_in_sz: data xfer size for READS

 */

static void

_base_build_nvme_prp(struct MPT3SAS_ADAPTER *ioc, u16 smid,
@@ -2311,8 +2312,8 @@ _base_build_nvme_prp(struct MPT3SAS_ADAPTER *ioc, u16 smid, 
}



/**

 * base_make_prp_nvme -

 * Prepare PRPs(Physical Region Page)- SGLs specific to NVMe drives only

 * base_make_prp_nvme - Prepare PRPs (Physical Region Page) -

 *			SGLs specific to NVMe drives only

 *

 * @ioc:		per adapter object

 * @scmd:		SCSI command from the mid-layer
@@ -3155,7 +3156,7 @@ _base_assign_reply_queues(struct MPT3SAS_ADAPTER *ioc) 
 *  - loaded driver with default max_msix_vectors module parameter and

 *  - system booted in non kdump mode

 *

 * returns nothing.

 * Return: nothing.

 */

static void

_base_check_and_enable_high_iops_queues(struct MPT3SAS_ADAPTER *ioc,
@@ -3368,7 +3369,7 @@ _base_diag_reset(struct MPT3SAS_ADAPTER *ioc); 
 *     and if it is in fault state then issue diag reset.

 * @ioc: per adapter object

 *

 * Returns: 0 for success, non-zero for failure.

 * Return: 0 for success, non-zero for failure.

 */

static int

_base_check_for_fault_and_issue_reset(struct MPT3SAS_ADAPTER *ioc)
@@ -3633,7 +3634,7 @@ mpt3sas_base_get_reply_virt_addr(struct MPT3SAS_ADAPTER *ioc, u32 phys_addr) 
 * @ioc: per adapter object

 * @scmd: scsi_cmnd object

 *

 * returns msix index of general reply queues,

 * Return: msix index of general reply queues,

 * i.e. reply queue on which IO request's reply

 * should be posted by the HBA firmware.

 */
@@ -3663,7 +3664,7 @@ _base_get_msix_index(struct MPT3SAS_ADAPTER *ioc, 
 * @ioc: per adapter object

 * @scmd: scsi_cmnd object

 *

 * Returns: msix index of high iops reply queues.

 * Return: msix index of high iops reply queues.

 * i.e. high iops reply queue on which IO request's

 * reply should be posted by the HBA firmware.

 */
@@ -3910,7 +3911,7 @@ _base_writeq(__u64 b, volatile void __iomem *addr, spinlock_t *writeq_lock) 
 * @ioc: per adapter object

 * @smid: system request message index

 *

 * returns msix index.

 * Return: msix index.

 */

static u8

_base_set_and_get_msix_index(struct MPT3SAS_ADAPTER *ioc, u16 smid)
@@ -4005,7 +4006,7 @@ _base_put_smid_fast_path(struct MPT3SAS_ADAPTER *ioc, u16 smid, 
 * _base_put_smid_hi_priority - send Task Management request to firmware

 * @ioc: per adapter object

 * @smid: system request message index

 * @msix_task: msix_task will be same as msix of IO incase of task abort else 0.

 * @msix_task: msix_task will be same as msix of IO in case of task abort else 0

 */

static void

_base_put_smid_hi_priority(struct MPT3SAS_ADAPTER *ioc, u16 smid,
@@ -4109,7 +4110,7 @@ _base_put_smid_default(struct MPT3SAS_ADAPTER *ioc, u16 smid) 
 * @smid: system request message index

 * @handle: device handle, unused in this function, for function type match

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_put_smid_scsi_io_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid,
@@ -4131,7 +4132,7 @@ _base_put_smid_scsi_io_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid, 
 * @ioc: per adapter object

 * @smid: system request message index

 * @handle: device handle, unused in this function, for function type match

 * Return nothing

 * Return: nothing

 */

static void

_base_put_smid_fast_path_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid,
@@ -4154,7 +4155,7 @@ _base_put_smid_fast_path_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid, 
 * @smid: system request message index

 * @msix_task: msix_task will be same as msix of IO in case of task abort else 0

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_put_smid_hi_priority_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid,
@@ -4176,7 +4177,7 @@ _base_put_smid_hi_priority_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid, 
 * @ioc: per adapter object

 * @smid: system request message index

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_put_smid_default_atomic(struct MPT3SAS_ADAPTER *ioc, u16 smid)
@@ -4547,7 +4548,7 @@ _base_display_fwpkg_version(struct MPT3SAS_ADAPTER *ioc) 
}



/**

 * _base_display_ioc_capabilities - Disply IOC's capabilities.

 * _base_display_ioc_capabilities - Display IOC's capabilities.

 * @ioc: per adapter object

 */

static void
@@ -4750,7 +4751,7 @@ mpt3sas_base_update_missing_delay(struct MPT3SAS_ADAPTER *ioc, 
 *    according to performance mode.

 * @ioc : per adapter object

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_update_ioc_page1_inlinewith_perf_mode(struct MPT3SAS_ADAPTER *ioc)
@@ -4815,7 +4816,7 @@ _base_update_ioc_page1_inlinewith_perf_mode(struct MPT3SAS_ADAPTER *ioc) 
 *				persistent pages

 * @ioc : per adapter object

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_get_event_diag_triggers(struct MPT3SAS_ADAPTER *ioc)
@@ -4866,7 +4867,7 @@ _base_get_event_diag_triggers(struct MPT3SAS_ADAPTER *ioc) 
 *				persistent pages

 * @ioc : per adapter object

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_get_scsi_diag_triggers(struct MPT3SAS_ADAPTER *ioc)
@@ -4917,7 +4918,7 @@ _base_get_scsi_diag_triggers(struct MPT3SAS_ADAPTER *ioc) 
 *				persistent pages

 * @ioc : per adapter object

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_get_mpi_diag_triggers(struct MPT3SAS_ADAPTER *ioc)
@@ -4970,7 +4971,7 @@ _base_get_mpi_diag_triggers(struct MPT3SAS_ADAPTER *ioc) 
 *				persistent pages

 * @ioc : per adapter object

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_get_master_diag_triggers(struct MPT3SAS_ADAPTER *ioc)
@@ -5006,8 +5007,8 @@ _base_get_master_diag_triggers(struct MPT3SAS_ADAPTER *ioc) 
 *					driver trigger pages or not

 * @ioc : per adapter object

 *

 * Returns trigger flags mask if HBA FW supports driver trigger pages,

 * otherwise returns EFAULT.

 * Return: trigger flags mask if HBA FW supports driver trigger pages,

 * otherwise returns %-EFAULT.

 */

static int

_base_check_for_trigger_pages_support(struct MPT3SAS_ADAPTER *ioc)
@@ -5035,7 +5036,7 @@ _base_check_for_trigger_pages_support(struct MPT3SAS_ADAPTER *ioc) 
 *				persistent pages.

 * @ioc : per adapter object

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_get_diag_triggers(struct MPT3SAS_ADAPTER *ioc)
@@ -5092,7 +5093,7 @@ _base_get_diag_triggers(struct MPT3SAS_ADAPTER *ioc) 
 *			trigger pages.

 * @ioc : per adapter object

 *

 * Return nothing.

 * Return: nothing.

 */

static void

_base_update_diag_trigger_pages(struct MPT3SAS_ADAPTER *ioc)
@@ -6233,7 +6234,7 @@ _base_wait_on_iocstate(struct MPT3SAS_ADAPTER *ioc, u32 ioc_state, int timeout) 
 * _base_dump_reg_set -	This function will print hexdump of register set.

 * @ioc: per adapter object

 *

 * Returns nothing.

 * Return: nothing.

 */

static inline void

_base_dump_reg_set(struct MPT3SAS_ADAPTER *ioc)
@@ -6467,7 +6468,7 @@ _base_send_ioc_reset(struct MPT3SAS_ADAPTER *ioc, u8 reset_type, int timeout) 
 *

 * Return: Waits up to timeout seconds for the IOC to

 * become operational. Returns 0 if IOC is present

 * and operational; otherwise returns -EFAULT.

 * and operational; otherwise returns %-EFAULT.

 */



int
@@ -7868,7 +7869,7 @@ mpt3sas_base_attach(struct MPT3SAS_ADAPTER *ioc) 
		/*

		 * In SAS3.0,

		 * SCSI_IO, SMP_PASSTHRU, SATA_PASSTHRU, Target Assist, and

		 * Target Status - all require the IEEE formated scatter gather

		 * Target Status - all require the IEEE formatted scatter gather

		 * elements.

		 */

		ioc->build_sg_scmd = &_base_build_sg_scmd_ieee;