Commit 290fdc4b authored by Zhen Lei's avatar Zhen Lei Committed by Thomas Gleixner
Browse files

genirq/timings: Fix error return code in irq_timings_test_irqs() 



Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.

Fixes: f52da98d ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com
parent 92848731

kernel/irq/timings.c

+2 −0
Original line number Diff line number Diff line
@@ -794,12 +794,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti) 


		__irq_timings_store(irq, irqs, ti->intervals[i]);

		if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {

			ret = -EBADSLT;

			pr_err("Failed to store in the circular buffer\n");

			goto out;

		}

	}



	if (irqs->count != ti->count) {

		ret = -ERANGE;

		pr_err("Count differs\n");

		goto out;

	}