Unverified Commit 290c3230 authored Mar 01, 2021 by Pierre-Louis Bossart Committed by Mark Brown Mar 02, 2021

ASoC: SOF: Intel: unregister DMIC device on probe error

We only unregister the platform device during the .remove operation,
but if the probe fails we will never reach this sequence.

Suggested-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Fixes: dd96daca ("ASoC: SOF: Intel: Add APL/CNL HW DSP support")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20210302003410.1178535-1-pierre-louis.bossart@linux.intel.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent d27f8fea

sound/soc/sof/intel/hda.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -895,6 +895,7 @@ int hda_dsp_probe(struct snd_sof_dev *sdev)
		/* dsp_unmap: not currently used */
		iounmap(sdev->bar[HDA_DSP_BAR]);
		hdac_bus_unmap:
		platform_device_unregister(hdev->dmic_dev);
		iounmap(bus->remap_addr);
		hda_codec_i915_exit(sdev);
		err: