Commit 2900bcbe authored by Valentin Schneider's avatar Valentin Schneider Committed by Steven Rostedt (Google)
Browse files

tracing/filters: Change parse_pred() cpulist ternary into an if block 

Review comments noted that an if block would be clearer than a ternary, so
swap it out.

No change in behaviour intended

Link: https://lkml.kernel.org/r/20230901151039.125186-4-vschneid@redhat.com



Cc: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: default avatarValentin Schneider <vschneid@redhat.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 1caf7adb

kernel/trace/trace_events_filter.c

+6 −2
Original line number Diff line number Diff line
@@ -1782,13 +1782,17 @@ static int parse_pred(const char *str, void *data, 
				FILTER_PRED_FN_CPUMASK;

		} else if (field->filter_type == FILTER_CPU) {

			if (single) {

				pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;

				if (pred->op == OP_BAND)

					pred->op = OP_EQ;



				pred->fn_num = FILTER_PRED_FN_CPU;

			} else {

				pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK;

			}

		} else if (single) {

			pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;

			if (pred->op == OP_BAND)

				pred->op = OP_EQ;



			pred->fn_num = select_comparison_fn(pred->op, field->size, false);

			if (pred->op == OP_NE)

				pred->not = 1;