Commit 28e8190d authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

tun: Use memdup_user() rather than duplicating its implementation 



Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarShmulik Ladkani <shmulik.ladkani@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4825a4e4

drivers/net/tun.c

+3 −8
Original line number Diff line number Diff line
@@ -731,14 +731,9 @@ static int update_filter(struct tap_filter *filter, void __user *arg) 
	}



	alen = ETH_ALEN * uf.count;

	addr = kmalloc(alen, GFP_KERNEL);

	if (!addr)

		return -ENOMEM;



	if (copy_from_user(addr, arg + sizeof(uf), alen)) {

		err = -EFAULT;

		goto done;

	}

	addr = memdup_user(arg + sizeof(uf), alen);

	if (IS_ERR(addr))

		return PTR_ERR(addr);



	/* The filter is updated without holding any locks. Which is

	 * perfectly safe. We disable it first and in the worst