Commit 28e70ed9 authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Jon Mason
Browse files

ntb: amd: Drop unnecessary error check for debugfs_create_dir 



This patch removes the error checking for debugfs_create_dir in
ntb_hw_amd.c. This is because the DebugFS kernel API is developed
in a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes. The debugfs APIs have
a IS_ERR() judge in start_creating() which can handle it
gracefully. so these checks are unnecessary.

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Acked-by: default avatarSanjay R Mehta <sanju.mehta@amd.com>
Signed-off-by: default avatarJon Mason <jdmason@kudzu.us>
parent 03c9e6f0

drivers/ntb/hw/amd/ntb_hw_amd.c

+4 −7
Original line number Diff line number Diff line
@@ -941,9 +941,6 @@ static void ndev_init_debugfs(struct amd_ntb_dev *ndev) 
		ndev->debugfs_dir =

			debugfs_create_dir(pci_name(ndev->ntb.pdev),

					   debugfs_dir);

		if (IS_ERR(ndev->debugfs_dir))

			ndev->debugfs_info = NULL;

		else

		ndev->debugfs_info =

			debugfs_create_file("info", S_IRUSR,

					    ndev->debugfs_dir, ndev,