Commit 28e538a3 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

blk-cgroup: fix freeing NULL blkg in blkg_create 



new_blkg can be NULL if the caller didn't pass in a pre-allocated blkg.
Don't try to free it in that case.

Fixes: 27b642b0 ("blk-cgroup: simplify blkg freeing from initialization failure paths")
Reported-by: default avatarYi Zhang <yi.zhang@redhat.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20230206150201.3438972-1-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 1eb9cd15

block/blk-cgroup.c

+2 −1
Original line number Diff line number Diff line
@@ -383,6 +383,7 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg, struct gendisk *disk, 
err_put_css:

	css_put(&blkcg->css);

err_free_blkg:

	if (new_blkg)

		blkg_free(new_blkg);

	return ERR_PTR(ret);

}