Commit 28e36712 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Hans de Goede
Browse files

platform/x86: toshiba_acpi: Fix missing error code in toshiba_acpi_setup_keyboard() 



The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'error'.

Eliminate the follow smatch warning:

drivers/platform/x86/toshiba_acpi.c:2834 toshiba_acpi_setup_keyboard()
warn: missing error code 'error'.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1622628348-87035-1-git-send-email-jiapeng.chong@linux.alibaba.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent f7b056b4

drivers/platform/x86/toshiba_acpi.c

+1 −0
Original line number Diff line number Diff line
@@ -2831,6 +2831,7 @@ static int toshiba_acpi_setup_keyboard(struct toshiba_acpi_dev *dev) 


	if (!dev->info_supported && !dev->system_event_supported) {

		pr_warn("No hotkey query interface found\n");

		error = -EINVAL;

		goto err_remove_filter;

	}