Commit 28bba1e2 authored by Zhen Lei's avatar Zhen Lei Committed by Lorenzo Pieralisi
Browse files

PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup() 

When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Link: https://lore.kernel.org/r/20210511122453.6052-1-thunder.leizhen@huawei.com


Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: default avatarKrzysztof Wilczyński <kw@linux.com>
parent 6efb943b

drivers/pci/controller/pcie-mediatek.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -991,11 +991,9 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie) 
	regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "subsys");

	regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "subsys");

	if (regs) {

	if (regs) {

		pcie->base = devm_ioremap_resource(dev, regs);

		pcie->base = devm_ioremap_resource(dev, regs);

		if (IS_ERR(pcie->base)) {

		if (IS_ERR(pcie->base))

			dev_err(dev, "failed to map shared register\n");

			return PTR_ERR(pcie->base);

			return PTR_ERR(pcie->base);

	}

	}

	}





	pcie->free_ck = devm_clk_get(dev, "free_ck");

	pcie->free_ck = devm_clk_get(dev, "free_ck");

	if (IS_ERR(pcie->free_ck)) {

	if (IS_ERR(pcie->free_ck)) {