Commit 28738fab authored by Muhammad Usama Anjum's avatar Muhammad Usama Anjum Committed by Juergen Gross
Browse files

xen/pciback: Fix incorrect type warnings 



Correct enum pci_channel_io_normal should be used instead of putting
integer value 1.

Fix following smatch warnings:
drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types)
drivers/xen/xen-pciback/pci_stub.c:805:40:    expected restricted pci_channel_state_t [usertype] state
drivers/xen/xen-pciback/pci_stub.c:805:40:    got int
drivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in argument 2 (different base types)
drivers/xen/xen-pciback/pci_stub.c:862:40:    expected restricted pci_channel_state_t [usertype] state
drivers/xen/xen-pciback/pci_stub.c:862:40:    got int
drivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in argument 2 (different base types)
drivers/xen/xen-pciback/pci_stub.c:973:31:    expected restricted pci_channel_state_t [usertype] state
drivers/xen/xen-pciback/pci_stub.c:973:31:    got int

Signed-off-by: default avatarMuhammad Usama Anjum <musamaanjum@gmail.com>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20210326181442.GA1735905@LEGION


Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent bf05bf16

drivers/xen/xen-pciback/pci_stub.c

+3 −3
Original line number Diff line number Diff line
@@ -802,7 +802,7 @@ static pci_ers_result_t xen_pcibk_slot_reset(struct pci_dev *dev) 
			"guest with no AER driver should have been killed\n");

		goto end;

	}

	result = common_process(psdev, 1, XEN_PCI_OP_aer_slotreset, result);

	result = common_process(psdev, pci_channel_io_normal, XEN_PCI_OP_aer_slotreset, result);



	if (result == PCI_ERS_RESULT_NONE ||

		result == PCI_ERS_RESULT_DISCONNECT) {
@@ -859,7 +859,7 @@ static pci_ers_result_t xen_pcibk_mmio_enabled(struct pci_dev *dev) 
			"guest with no AER driver should have been killed\n");

		goto end;

	}

	result = common_process(psdev, 1, XEN_PCI_OP_aer_mmio, result);

	result = common_process(psdev, pci_channel_io_normal, XEN_PCI_OP_aer_mmio, result);



	if (result == PCI_ERS_RESULT_NONE ||

		result == PCI_ERS_RESULT_DISCONNECT) {
@@ -970,7 +970,7 @@ static void xen_pcibk_error_resume(struct pci_dev *dev) 
		kill_domain_by_device(psdev);

		goto end;

	}

	common_process(psdev, 1, XEN_PCI_OP_aer_resume,

	common_process(psdev, pci_channel_io_normal, XEN_PCI_OP_aer_resume,

		       PCI_ERS_RESULT_RECOVERED);

end:

	if (psdev)