Commit 287273a8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans de Goede
Browse files

platform/mellanox: mlxreg-lc: fix error code in mlxreg_lc_create_static_devices() 



This code should be using PTR_ERR() instead of IS_ERR().  And because
it's using the wrong "dev->client" pointer, the IS_ERR() check will be
false, meaning the function returns success.

Fixes: 62f9529b ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarVadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/20211110074346.GB5176@kili


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent fa55b7dc

drivers/platform/mellanox/mlxreg-lc.c

+3 −2
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl 
				int size)

{

	struct mlxreg_hotplug_device *dev = devs;

	int i;

	int i, ret;



	/* Create static I2C device feeding by auxiliary or main power. */

	for (i = 0; i < size; i++, dev++) {
@@ -423,6 +423,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl 
				dev->brdinfo->type, dev->nr, dev->brdinfo->addr);



			dev->adapter = NULL;

			ret = PTR_ERR(dev->client);

			goto fail_create_static_devices;

		}

	}
@@ -435,7 +436,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl 
		i2c_unregister_device(dev->client);

		dev->client = NULL;

	}

	return IS_ERR(dev->client);

	return ret;

}



static void