Commit 28616ed1 authored by Cai Huoqing's avatar Cai Huoqing Committed by Marc Kleine-Budde
Browse files

can: mscan: mpc5xxx_can: Make use of the helper function dev_err_probe() 

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Link: https://lore.kernel.org/all/20210915145726.7092-1-caihuoqing@baidu.com


Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 39aab460

drivers/net/can/mscan/mpc5xxx_can.c

+2 −4
Original line number Diff line number Diff line
@@ -293,10 +293,8 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev) 
		return -EINVAL;



	base = of_iomap(np, 0);

	if (!base) {

		dev_err(&ofdev->dev, "couldn't ioremap\n");

		return err;

	}

	if (!base)

		return dev_err_probe(&ofdev->dev, err, "couldn't ioremap\n");



	irq = irq_of_parse_and_map(np, 0);

	if (!irq) {