Commit 282657a8 authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by Jarkko Sakkinen
Browse files

tpm, tpm_tis: Claim locality before writing TPM_INT_ENABLE register 



In disable_interrupts() the TPM_GLOBAL_INT_ENABLE bit is unset in the
TPM_INT_ENABLE register to shut the interrupts off. However modifying the
register is only possible with a held locality. So claim the locality
before disable_interrupts() is called.

Signed-off-by: default avatarLino Sanfilippo <l.sanfilippo@kunbus.com>
Tested-by: default avatarMichael Niewöhner <linux@mniewoehner.de>
Tested-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent 858e8b79

drivers/char/tpm/tpm_tis_core.c

+4 −0
Original line number Diff line number Diff line
@@ -1102,7 +1102,11 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, 
				dev_err(&chip->dev, FW_BUG

					"TPM interrupt not working, polling instead\n");



				rc = request_locality(chip, 0);

				if (rc < 0)

					goto out_err;

				disable_interrupts(chip);

				release_locality(chip, 0);

			}

		} else {

			tpm_tis_probe_irq(chip, intmask);