Commit 280ee3c3 authored by Yang Yingliang's avatar Yang Yingliang Committed by Herbert Xu
Browse files

crypto: octeontx2 - fix missing unlock 



Add the missing unlock before return from error path.

Fixes: 4363f3d3 ("crypto: octeontx2 - add synchronization between mailbox accesses")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e6205ad5

drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c

+3 −1
Original line number Diff line number Diff line
@@ -143,8 +143,10 @@ static void cptpf_flr_wq_handler(struct work_struct *work) 
	mutex_lock(&pf->lock);

	req = otx2_mbox_alloc_msg_rsp(mbox, 0, sizeof(*req),

				      sizeof(struct msg_rsp));

	if (!req)

	if (!req) {

		mutex_unlock(&pf->lock);

		return;

	}



	req->sig = OTX2_MBOX_REQ_SIG;

	req->id = MBOX_MSG_VF_FLR;

drivers/crypto/marvell/octeontx2/otx2_cptpf_mbox.c

+3 −1
Original line number Diff line number Diff line
@@ -20,8 +20,10 @@ static int forward_to_af(struct otx2_cptpf_dev *cptpf, 


	mutex_lock(&cptpf->lock);

	msg = otx2_mbox_alloc_msg(&cptpf->afpf_mbox, 0, size);

	if (msg == NULL)

	if (msg == NULL) {

		mutex_unlock(&cptpf->lock);

		return -ENOMEM;

	}



	memcpy((uint8_t *)msg + sizeof(struct mbox_msghdr),

	       (uint8_t *)req + sizeof(struct mbox_msghdr), size);