Commit 280e7f90 authored by Barry Song's avatar Barry Song Committed by Vinod Koul
Browse files

dmaengine: milbeaut-xdmac: remove redundant irqsave and irqrestore in hardIRQ 



Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled
IRQ. This patch removes the irqsave and irqstore to save some instruction
cycles.

Signed-off-by: default avatarBarry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20201027215252.25820-6-song.bao.hua@hisilicon.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 654115e3

drivers/dma/milbeaut-xdmac.c

+2 −3
Original line number Diff line number Diff line
@@ -160,10 +160,9 @@ static irqreturn_t milbeaut_xdmac_interrupt(int irq, void *dev_id) 
{

	struct milbeaut_xdmac_chan *mc = dev_id;

	struct milbeaut_xdmac_desc *md;

	unsigned long flags;

	u32 val;



	spin_lock_irqsave(&mc->vc.lock, flags);

	spin_lock(&mc->vc.lock);



	/* Ack and Stop */

	val = FIELD_PREP(M10V_XDDSD_IS_MASK, 0x0);
@@ -177,7 +176,7 @@ static irqreturn_t milbeaut_xdmac_interrupt(int irq, void *dev_id) 


	milbeaut_xdmac_start(mc);

out:

	spin_unlock_irqrestore(&mc->vc.lock, flags);

	spin_unlock(&mc->vc.lock);

	return IRQ_HANDLED;

}