Commit 280bef51 authored by Kaige Fu's avatar Kaige Fu Committed by Marc Zyngier
Browse files

irqchip/gic-v3-its: Fix potential VPE leak on error 



In its_vpe_irq_domain_alloc, when its_vpe_init() returns an error,
there is an off-by-one in the number of VPEs to be freed.

Fix it by simply passing the number of VPEs allocated, which is the
index of the loop iterating over the VPEs.

Fixes: 7d75bbb4 ("irqchip/gic-v3-its: Add VPE irq domain allocation/teardown")
Signed-off-by: default avatarKaige Fu <kaige.fu@linux.alibaba.com>
[maz: fixed commit message]
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/d9e36dee512e63670287ed9eff884a5d8d6d27f2.1631672311.git.kaige.fu@linux.alibaba.com
parent 969ac78d

drivers/irqchip/irq-gic-v3-its.c

+1 −1
Original line number Diff line number Diff line
@@ -4501,7 +4501,7 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq 


	if (err) {

		if (i > 0)

			its_vpe_irq_domain_free(domain, virq, i - 1);

			its_vpe_irq_domain_free(domain, virq, i);



		its_lpi_free(bitmap, base, nr_ids);

		its_free_prop_table(vprop_page);