Commit 27ec43c7 authored by Parker Newman's avatar Parker Newman Committed by Wolfram Sang
Browse files

i2c: tegra: Fix i2c-tegra DMA config option processing 



Tegra processors prior to Tegra186 used APB DMA for I2C requiring
CONFIG_TEGRA20_APB_DMA=y while Tegra186 and later use GPC DMA requiring
CONFIG_TEGRA186_GPC_DMA=y.

The check for if the processor uses APB DMA is inverted and so the wrong
DMA config options are checked.

This means if CONFIG_TEGRA20_APB_DMA=y but CONFIG_TEGRA186_GPC_DMA=n
with a Tegra186 or later processor the driver will incorrectly think DMA is
enabled and attempt to request DMA channels that will never be availible,
leaving the driver in a perpetual EPROBE_DEFER state.

Fixes: 48cb6356 ("i2c: tegra: Add GPCDMA support")
Signed-off-by: default avatarParker Newman <pnewman@connecttech.com>
Acked-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Acked-by: default avatarAkhil R <akhilrajeev@nvidia.com>
Link: https://lore.kernel.org/r/fcfcf9b3-c8c4-9b34-2ff8-cd60a3d490bd@connecttech.com


Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent b3497ef4

drivers/i2c/busses/i2c-tegra.c

+1 −1
Original line number Diff line number Diff line
@@ -442,7 +442,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) 
	if (IS_VI(i2c_dev))

		return 0;



	if (!i2c_dev->hw->has_apb_dma) {

	if (i2c_dev->hw->has_apb_dma) {

		if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {

			dev_dbg(i2c_dev->dev, "APB DMA support not enabled\n");

			return 0;