Unverified Commit 27b196c1 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: Intel: atom: don't keep a temporary string in fixup_tplg_name 



fixup_tplg_name() doesn't need to keep the string, allocated for
filename - it's temporary.

Inspired by similar change for hda:
commit b9088535 ("ASoC: SOF: Intel: HDA: don't keep a temporary variable")

Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220715145216.277003-8-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b9cb044f

sound/soc/sof/intel/atom.c

+8 −8
Original line number Diff line number Diff line
@@ -274,22 +274,22 @@ static const char *fixup_tplg_name(struct snd_sof_dev *sdev, 
				   const char *ssp_str)

{

	const char *tplg_filename = NULL;

	char *filename;

	char *split_ext;

	const char *split_ext;

	char *filename, *tmp;



	filename = devm_kstrdup(sdev->dev, sof_tplg_filename, GFP_KERNEL);

	filename = kstrdup(sof_tplg_filename, GFP_KERNEL);

	if (!filename)

		return NULL;



	/* this assumes a .tplg extension */

	split_ext = strsep(&filename, ".");

	if (split_ext) {

	tmp = filename;

	split_ext = strsep(&tmp, ".");

	if (split_ext)

		tplg_filename = devm_kasprintf(sdev->dev, GFP_KERNEL,

					       "%s-%s.tplg",

					       split_ext, ssp_str);

		if (!tplg_filename)

			return NULL;

	}

	kfree(filename);



	return tplg_filename;

}