Commit 27a221f4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

iwlwifi: mvm: d3: Fix off by ones in iwl_mvm_wowlan_get_rsc_v5_data() 



These should be >= ARRAY_SIZE() instead of > ARRAY_SIZE() to prevent an
out of bounds write on the next line.

Fixes: 79e561f0 ("iwlwifi: mvm: d3: implement RSC command version 5")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarLuca Coelho <luca@coelho.fi>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210831081802.GA9846@kili
parent 24d5f16e

drivers/net/wireless/intel/iwlwifi/mvm/d3.c

+2 −2
Original line number Diff line number Diff line
@@ -360,11 +360,11 @@ static void iwl_mvm_wowlan_get_rsc_v5_data(struct ieee80211_hw *hw, 
	if (sta) {

		rsc = data->rsc->ucast_rsc;

	} else {

		if (WARN_ON(data->gtks > ARRAY_SIZE(data->gtk_ids)))

		if (WARN_ON(data->gtks >= ARRAY_SIZE(data->gtk_ids)))

			return;

		data->gtk_ids[data->gtks] = key->keyidx;

		rsc = data->rsc->mcast_rsc[data->gtks % 2];

		if (WARN_ON(key->keyidx >

		if (WARN_ON(key->keyidx >=

				ARRAY_SIZE(data->rsc->mcast_key_id_map)))

			return;

		data->rsc->mcast_key_id_map[key->keyidx] = data->gtks % 2;