Commit 278e5bbd authored by Qinglang Miao's avatar Qinglang Miao Committed by Wolfram Sang
Browse files

i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails 



The PM reference count is not expected to be incremented on
return in lpi2c_imx_master_enable.

However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 13d6eb20 ("i2c: imx-lpi2c: add runtime pm support")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 223125e3

drivers/i2c/busses/i2c-imx-lpi2c.c

+1 −1
Original line number Diff line number Diff line
@@ -259,7 +259,7 @@ static int lpi2c_imx_master_enable(struct lpi2c_imx_struct *lpi2c_imx) 
	unsigned int temp;

	int ret;



	ret = pm_runtime_get_sync(lpi2c_imx->adapter.dev.parent);

	ret = pm_runtime_resume_and_get(lpi2c_imx->adapter.dev.parent);

	if (ret < 0)

		return ret;