Commit 277f2bb1 authored by Sukadev Bhattiprolu's avatar Sukadev Bhattiprolu Committed by Jakub Kicinski
Browse files

ibmvnic: schedule failover only if vioctl fails 



If client is unable to initiate a failover reset via H_VIOCTL hcall, then
it should schedule a failover reset as a last resort. Otherwise, there is
no need to do a last resort.

Fixes: 334c4241 ("ibmvnic: improve failover sysfs entry")
Reported-by: default avatarCris Forno <cforno12@outlook.com>
Signed-off-by: default avatarSukadev Bhattiprolu <sukadev@linux.ibm.com>
Signed-off-by: default avatarDany Madden <drt@linux.ibm.com>
Link: https://lore.kernel.org/r/20220221210545.115283-1-drt@linux.ibm.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 342b6419

drivers/net/ethernet/ibm/ibmvnic.c

+5 −1
Original line number Diff line number Diff line
@@ -5917,10 +5917,14 @@ static ssize_t failover_store(struct device *dev, struct device_attribute *attr, 
		   be64_to_cpu(session_token));

	rc = plpar_hcall_norets(H_VIOCTL, adapter->vdev->unit_address,

				H_SESSION_ERR_DETECTED, session_token, 0, 0);

	if (rc)

	if (rc) {

		netdev_err(netdev,

			   "H_VIOCTL initiated failover failed, rc %ld\n",

			   rc);

		goto last_resort;

	}



	return count;



last_resort:

	netdev_dbg(netdev, "Trying to send CRQ_CMD, the last resort\n");