Commit 2731aa7d authored by Anna-Maria Behnsen's avatar Anna-Maria Behnsen Committed by Thomas Gleixner
Browse files

timers: Initialize base::next_expiry_recalc in timers_prepare_cpu() 



When base::next_expiry_recalc is not initialized to false during cpu
bringup in HOTPLUG_CPU and is accidently true and no timer is queued in the
meantime, the loop through the wheel to find __next_timer_interrupt() might
be done for nothing.

Therefore initialize base::next_expiry_recalc to false in
timers_prepare_cpu().

Signed-off-by: default avatarAnna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20220405191732.7438-2-anna-maria@linutronix.de
parent c54bc0fc

kernel/time/timer.c

+1 −0
Original line number Diff line number Diff line
@@ -1953,6 +1953,7 @@ int timers_prepare_cpu(unsigned int cpu) 
		base = per_cpu_ptr(&timer_bases[b], cpu);

		base->clk = jiffies;

		base->next_expiry = base->clk + NEXT_TIMER_MAX_DELTA;

		base->next_expiry_recalc = false;

		base->timers_pending = false;

		base->is_idle = false;

	}