Commit 272e4f99 authored by Joerg Roedel's avatar Joerg Roedel
Browse files

iommu/amd: WARN when __[attach|detach]_device are called with irqs enabled 



These functions rely on being called with IRQs disabled. Add
a WARN_ON to detect early when its not.

Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent f1dd0a8b

drivers/iommu/amd_iommu.c

+12 −0
Original line number Diff line number Diff line
@@ -2030,6 +2030,12 @@ static int __attach_device(struct iommu_dev_data *dev_data, 
{

	int ret;



	/*

	 * Must be called with IRQs disabled. Warn here to detect early

	 * when its not.

	 */

	WARN_ON(!irqs_disabled());



	/* lock domain */

	spin_lock(&domain->lock);
@@ -2190,6 +2196,12 @@ static void __detach_device(struct iommu_dev_data *dev_data) 
{

	struct protection_domain *domain;



	/*

	 * Must be called with IRQs disabled. Warn here to detect early

	 * when its not.

	 */

	WARN_ON(!irqs_disabled());



	if (WARN_ON(!dev_data->domain))

		return;