Commit 272bba19 authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Leon Romanovsky
Browse files

RDMA: Remove unnecessary ternary operators 



There are a little ternary operators, the true or false judgment
of which is unnecessary in C language semantics.

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230731085118.394443-1-ruanjinjie@huawei.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent f0ff2a2d

drivers/infiniband/core/netlink.c

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ static bool is_nl_msg_valid(unsigned int type, unsigned int op) 
	if (type >= RDMA_NL_NUM_CLIENTS)

		return false;



	return (op < max_num_ops[type]) ? true : false;

	return op < max_num_ops[type];

}



static const struct rdma_nl_cbs *

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+2 −3
Original line number Diff line number Diff line
@@ -1336,8 +1336,7 @@ static int bnxt_re_init_qp_attr(struct bnxt_re_qp *qp, struct bnxt_re_pd *pd, 
	qplqp->pd = &pd->qplib_pd;

	qplqp->qp_handle = (u64)qplqp;

	qplqp->max_inline_data = init_attr->cap.max_inline_data;

	qplqp->sig_type = ((init_attr->sq_sig_type == IB_SIGNAL_ALL_WR) ?

			    true : false);

	qplqp->sig_type = init_attr->sq_sig_type == IB_SIGNAL_ALL_WR;

	qptype = bnxt_re_init_qp_type(rdev, init_attr);

	if (qptype < 0) {

		rc = qptype;
@@ -2261,7 +2260,7 @@ static int bnxt_re_build_qp1_send_v2(struct bnxt_re_qp *qp, 
	}



	is_eth = true;

	is_vlan = (vlan_id && (vlan_id < 0x1000)) ? true : false;

	is_vlan = vlan_id && (vlan_id < 0x1000);



	ib_ud_header_init(payload_size, !is_eth, is_eth, is_vlan, is_grh,

			  ip_version, is_udp, 0, &qp->qp1_hdr);

drivers/infiniband/hw/bnxt_re/main.c

+3 −4
Original line number Diff line number Diff line
@@ -433,8 +433,8 @@ int bnxt_re_hwrm_qcaps(struct bnxt_re_dev *rdev) 
	cctx->modes.db_push = le32_to_cpu(resp.flags) & FUNC_QCAPS_RESP_FLAGS_WCB_PUSH_MODE;



	cctx->modes.dbr_pacing =

		le32_to_cpu(resp.flags_ext2) & FUNC_QCAPS_RESP_FLAGS_EXT2_DBR_PACING_EXT_SUPPORTED ?

		true : false;

		le32_to_cpu(resp.flags_ext2) &

		FUNC_QCAPS_RESP_FLAGS_EXT2_DBR_PACING_EXT_SUPPORTED;

	return 0;

}
@@ -1333,8 +1333,7 @@ static int bnxt_re_setup_qos(struct bnxt_re_dev *rdev) 
	 */

	if ((prio_map == 0 && rdev->qplib_res.prio) ||

	    (prio_map != 0 && !rdev->qplib_res.prio)) {

		rdev->qplib_res.prio = prio_map ? true : false;



		rdev->qplib_res.prio = prio_map;

		bnxt_re_update_gid(rdev);

	}

drivers/infiniband/hw/bnxt_re/qplib_fp.c

+1 −2
Original line number Diff line number Diff line
@@ -1373,8 +1373,7 @@ int bnxt_qplib_query_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp) 
	qp->state = sb->en_sqd_async_notify_state &

			CREQ_QUERY_QP_RESP_SB_STATE_MASK;

	qp->en_sqd_async_notify = sb->en_sqd_async_notify_state &

				  CREQ_QUERY_QP_RESP_SB_EN_SQD_ASYNC_NOTIFY ?

				  true : false;

				  CREQ_QUERY_QP_RESP_SB_EN_SQD_ASYNC_NOTIFY;

	qp->access = sb->access;

	qp->pkey_index = le16_to_cpu(sb->pkey);

	qp->qkey = le32_to_cpu(sb->qkey);

drivers/infiniband/hw/hns/hns_roce_hem.c

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ bool hns_roce_check_whether_mhop(struct hns_roce_dev *hr_dev, u32 type) 
		return false;

	}



	return hop_num ? true : false;

	return hop_num;

}



static bool hns_roce_check_hem_null(struct hns_roce_hem **hem, u64 hem_idx,