Commit 27244cbd authored Sep 07, 2022 by Alexander Sverdlin Committed by Rob Herring Sep 07, 2022

of: irq: Report individual failures in of_irq_init()



New pr_err(), a copy of preceeding pr_debug(), faciliates debugging.

This change was inspired by a long lasting debugging of the
octeon_irq_init_ciu() which fails completely silently and leaves the
interrupt controller half-way configured which in turn had very non-obvious
effects.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Link: https://lore.kernel.org/r/20220907121629.54330-1-alexander.sverdlin@nokia.com


Signed-off-by: Rob Herring <robh@kernel.org>

parent ed18a9b1

drivers/of/irq.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -592,6 +592,9 @@ void __init of_irq_init(const struct of_device_id *matches)
		ret = desc->irq_init_cb(desc->dev,
		desc->interrupt_parent);
		if (ret) {
		pr_err("%s: Failed to init %pOF (%p), parent %p\n",
		__func__, desc->dev, desc->dev,
		desc->interrupt_parent);
		of_node_clear_flag(desc->dev, OF_POPULATED);
		kfree(desc);
		continue;