Commit 2719cb44 authored by Lijun Pan's avatar Lijun Pan Committed by Jakub Kicinski
Browse files

ibmvnic: remove unnecessary rmb() inside ibmvnic_poll 



rmb() can be removed since:
1. pending_scrq() has dma_rmb() at the function end;
2. dma_rmb(), though weaker, is enough here.

Signed-off-by: default avatarLijun Pan <ljp@linux.ibm.com>
Acked-by: default avatarDwip Banerjee <dnbanerg@us.ibm.com>
Acked-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
Reviewed-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 665ab1eb

drivers/net/ethernet/ibm/ibmvnic.c

+0 −1
Original line number Diff line number Diff line
@@ -2510,7 +2510,6 @@ static int ibmvnic_poll(struct napi_struct *napi, int budget) 
		if (napi_complete_done(napi, frames_processed)) {

			enable_scrq_irq(adapter, rx_scrq);

			if (pending_scrq(adapter, rx_scrq)) {

				rmb();

				if (napi_reschedule(napi)) {

					disable_scrq_irq(adapter, rx_scrq);

					goto restart_poll;