Commit 26e35370 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by David S. Miller
Browse files

net/sched: act_pedit: Use kmemdup() to replace kmalloc + memcpy 



./net/sched/act_pedit.c:245:21-28: WARNING opportunity for kmemdup.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5478


Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: default avatarPedro Tammela <pctammela@mojatatu.com>
Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 132b4ebf

net/sched/act_pedit.c

+1 −3
Original line number Diff line number Diff line
@@ -242,14 +242,12 @@ static int tcf_pedit_init(struct net *net, struct nlattr *nla, 
	nparms->tcfp_flags = parm->flags;

	nparms->tcfp_nkeys = parm->nkeys;



	nparms->tcfp_keys = kmalloc(ksize, GFP_KERNEL);

	nparms->tcfp_keys = kmemdup(parm->keys, ksize, GFP_KERNEL);

	if (!nparms->tcfp_keys) {

		ret = -ENOMEM;

		goto put_chain;

	}



	memcpy(nparms->tcfp_keys, parm->keys, ksize);



	for (i = 0; i < nparms->tcfp_nkeys; ++i) {

		u32 offmask = nparms->tcfp_keys[i].offmask;

		u32 cur = nparms->tcfp_keys[i].off;