Commit 26921932 authored by Horatiu Vultur's avatar Horatiu Vultur Committed by Jakub Kicinski
Browse files

net: lan966x: Stop processing the MAC entry is port is wrong. 



Currently when getting a new MAC is learn, the HW generates an
interrupt. So then the SW will check the new entry and checks if it
arrived on a correct port. If it didn't just generate a warning.
But this could still crash the system. Therefore stop processing that
entry when an issue is seen.

Fixes: 5ccd66e0 ("net: lan966x: add support for interrupts from analyzer")
Signed-off-by: default avatarHoratiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d7a947d2

drivers/net/ethernet/microchip/lan966x/lan966x_mac.c

+4 −2
Original line number Diff line number Diff line
@@ -346,7 +346,8 @@ static void lan966x_mac_irq_process(struct lan966x *lan966x, u32 row, 


			lan966x_mac_process_raw_entry(&raw_entries[column],

						      mac, &vid, &dest_idx);

			WARN_ON(dest_idx > lan966x->num_phys_ports);

			if (WARN_ON(dest_idx > lan966x->num_phys_ports))

				continue;



			/* If the entry in SW is found, then there is nothing

			 * to do
@@ -392,7 +393,8 @@ static void lan966x_mac_irq_process(struct lan966x *lan966x, u32 row, 


		lan966x_mac_process_raw_entry(&raw_entries[column],

					      mac, &vid, &dest_idx);

		WARN_ON(dest_idx > lan966x->num_phys_ports);

		if (WARN_ON(dest_idx > lan966x->num_phys_ports))

			continue;



		mac_entry = lan966x_mac_alloc_entry(mac, vid, dest_idx);

		if (!mac_entry)