Commit 26894cd9 authored by Andrea Parri (Microsoft)'s avatar Andrea Parri (Microsoft) Committed by Jakub Kicinski
Browse files

hv_netvsc: Print value of invalid ID in netvsc_send_{completion,tx_complete}() 



That being useful for debugging purposes.

Notice that the packet descriptor is in "private" guest memory, so
that Hyper-V can not tamper with it.

While at it, remove two unnecessary u64-casts.

Signed-off-by: default avatarAndrea Parri (Microsoft) <parri.andrea@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4daf5f19

drivers/net/hyperv/netvsc.c

+4 −4
Original line number Diff line number Diff line
@@ -792,9 +792,9 @@ static void netvsc_send_tx_complete(struct net_device *ndev, 
	int queue_sends;

	u64 cmd_rqst;



	cmd_rqst = channel->request_addr_callback(channel, (u64)desc->trans_id);

	cmd_rqst = channel->request_addr_callback(channel, desc->trans_id);

	if (cmd_rqst == VMBUS_RQST_ERROR) {

		netdev_err(ndev, "Incorrect transaction id\n");

		netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);

		return;

	}
@@ -854,9 +854,9 @@ static void netvsc_send_completion(struct net_device *ndev, 
	/* First check if this is a VMBUS completion without data payload */

	if (!msglen) {

		cmd_rqst = incoming_channel->request_addr_callback(incoming_channel,

								   (u64)desc->trans_id);

								   desc->trans_id);

		if (cmd_rqst == VMBUS_RQST_ERROR) {

			netdev_err(ndev, "Invalid transaction id\n");

			netdev_err(ndev, "Invalid transaction ID %llx\n", desc->trans_id);

			return;

		}