Commit 265b0de2 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf probe: Add missing 0x prefix for addresses printed in hexadecimal 

To fix this confusing warning:

  # perf probe -l
  Failed to find debug information for address 798240
    probe_main:prometheus_new_counter__return (on github.com/prometheus/client_golang/prometheus.NewCounter%return in /home/acme/git/prometheus-uprobes/main with counter)
  #

As that 798240 is printed with PRIx64 but has no letters, better print
the 0x prefix to disambiguate.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/lkml/ZEBCyFu2GjTw6qOi@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 686c5118

tools/perf/util/probe-finder.c

+1 −1
Original line number Diff line number Diff line
@@ -1729,7 +1729,7 @@ int debuginfo__find_probe_point(struct debuginfo *dbg, u64 addr, 
		addr += baseaddr;

	/* Find cu die */

	if (!dwarf_addrdie(dbg->dbg, (Dwarf_Addr)addr, &cudie)) {

		pr_warning("Failed to find debug information for address %" PRIx64 "\n",

		pr_warning("Failed to find debug information for address %#" PRIx64 "\n",

			   addr);

		ret = -EINVAL;

		goto end;