Commit 263cb0cc authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Hans Verkuil
Browse files

media: imx-mipi-csis: Remove an incorrect fwnode_handle_put() call 



The commit in Fixes has removed an fwnode_graph_get_endpoint_by_id() call
in mipi_csis_subdev_init().
So the reference that was taken should not be released anymore in the
error handling path of the probe and in the remove function.

Remove the now incorrect fwnode_handle_put() calls.

Fixes: 1029939b ("media: v4l: async: Simplify async sub-device fwnode matching")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 735de5ca

drivers/media/platform/nxp/imx-mipi-csis.c

+0 −2
Original line number Diff line number Diff line
@@ -1490,7 +1490,6 @@ static int mipi_csis_probe(struct platform_device *pdev) 
	v4l2_async_unregister_subdev(&csis->sd);

err_disable_clock:

	mipi_csis_clk_disable(csis);

	fwnode_handle_put(csis->sd.fwnode);



	return ret;

}
@@ -1510,7 +1509,6 @@ static void mipi_csis_remove(struct platform_device *pdev) 
	mipi_csis_clk_disable(csis);

	v4l2_subdev_cleanup(&csis->sd);

	media_entity_cleanup(&csis->sd.entity);

	fwnode_handle_put(csis->sd.fwnode);

	pm_runtime_set_suspended(&pdev->dev);

}