Commit 262d9fcf authored by Xiao Yang's avatar Xiao Yang Committed by Jason Gunthorpe
Browse files

RDMA/rxe: Set partial attributes when completion status != IBV_WC_SUCCESS 

As ibv_poll_cq()'s manual said, only partial attributes are valid when
completion status != IBV_WC_SUCCESS.

Link: https://lore.kernel.org/r/20210930094813.226888-4-yangx.jy@fujitsu.com


Signed-off-by: default avatarXiao Yang <yangx.jy@fujitsu.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 609bb8c3

drivers/infiniband/sw/rxe/rxe_comp.c

+25 −20
Original line number Diff line number Diff line
@@ -380,30 +380,35 @@ static inline enum comp_state do_atomic(struct rxe_qp *qp, 
static void make_send_cqe(struct rxe_qp *qp, struct rxe_send_wqe *wqe,

			  struct rxe_cqe *cqe)

{

	struct ib_wc *wc = &cqe->ibwc;

	struct ib_uverbs_wc *uwc = &cqe->uibwc;



	memset(cqe, 0, sizeof(*cqe));



	if (!qp->is_user) {

		struct ib_wc		*wc	= &cqe->ibwc;



		wc->wr_id = wqe->wr.wr_id;

		wc->status = wqe->status;

		wc->qp = &qp->ibqp;

	} else {

		uwc->wr_id = wqe->wr.wr_id;

		uwc->status = wqe->status;

		uwc->qp_num = qp->ibqp.qp_num;

	}



	if (wqe->status == IB_WC_SUCCESS) {

		if (!qp->is_user) {

			wc->opcode = wr_to_wc_opcode(wqe->wr.opcode);

			if (wqe->wr.opcode == IB_WR_RDMA_WRITE_WITH_IMM ||

			    wqe->wr.opcode == IB_WR_SEND_WITH_IMM)

				wc->wc_flags = IB_WC_WITH_IMM;

			wc->byte_len = wqe->dma.length;

		wc->qp			= &qp->ibqp;

		} else {

		struct ib_uverbs_wc	*uwc	= &cqe->uibwc;



		uwc->wr_id		= wqe->wr.wr_id;

		uwc->status		= wqe->status;

			uwc->opcode = wr_to_wc_opcode(wqe->wr.opcode);

			if (wqe->wr.opcode == IB_WR_RDMA_WRITE_WITH_IMM ||

			    wqe->wr.opcode == IB_WR_SEND_WITH_IMM)

				uwc->wc_flags = IB_WC_WITH_IMM;

			uwc->byte_len = wqe->dma.length;

		uwc->qp_num		= qp->ibqp.qp_num;

		}

	}

}