Commit 260aecd6 authored by Wan Jiabing's avatar Wan Jiabing Committed by Joerg Roedel
Browse files

iommu/dart: Use kmemdup instead of kzalloc and memcpy 



Fix following coccicheck warning:
drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup

Signed-off-by: default avatarWan Jiabing <wanjiabing@vivo.com>
Acked-by: default avatarSven Peter <sven@svenpeter.dev>
Reviewed-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://lore.kernel.org/r/20211013063441.29888-1-wanjiabing@vivo.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 9e1ff307

drivers/iommu/apple-dart.c

+1 −2
Original line number Diff line number Diff line
@@ -702,13 +702,12 @@ static struct iommu_group *apple_dart_device_group(struct device *dev) 
	if (!group)

		goto out;



	group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL);

	group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL);

	if (!group_master_cfg) {

		iommu_group_put(group);

		goto out;

	}



	memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg));

	iommu_group_set_iommudata(group, group_master_cfg,

		apple_dart_release_group);