Commit 25ddd7cf authored by Douglas Anderson's avatar Douglas Anderson Committed by Jiri Kosina
Browse files

HID: i2c-hid: goodix: Use the devm variant of regulator_register_notifier() 



In commit 18eeef46 ("HID: i2c-hid: goodix: Tie the reset line to
true state of the regulator") I added a call to
regulator_register_notifier() but no call to unregister. That's a
bug. Let's use the devm variant to handle the unregistering.

Fixes: 18eeef46 ("HID: i2c-hid: goodix: Tie the reset line to true state of the regulator")
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 18eeef46

drivers/hid/i2c-hid/i2c-hid-of-goodix.c

+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ static int i2c_hid_of_goodix_probe(struct i2c_client *client, 
	 */

	mutex_lock(&ihid_goodix->regulator_mutex);

	ihid_goodix->nb.notifier_call = ihid_goodix_vdd_notify;

	ret = regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);

	ret = devm_regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);

	if (ret) {

		mutex_unlock(&ihid_goodix->regulator_mutex);

		return dev_err_probe(&client->dev, ret,