Commit 25c21d20 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: aacraid: Fix an oops in error handling 

If the memdup_user() function fails then it results in an Oops in the
error handling code when we try to kfree() and error pointer.

Link: https://lore.kernel.org/r/20200513093703.GB347693@mwanda


Fixes: 8d925b1f ("scsi: aacraid: Use memdup_user() as a cleanup")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 55ce24b3

drivers/scsi/aacraid/commctrl.c

+1 −0
Original line number Diff line number Diff line
@@ -516,6 +516,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) 
	user_srbcmd = memdup_user(user_srb, fibsize);

	if (IS_ERR(user_srbcmd)) {

		rcode = PTR_ERR(user_srbcmd);

		user_srbcmd = NULL;

		goto cleanup;

	}