Commit 25b12a58 authored by Andrey Konovalov's avatar Andrey Konovalov Committed by Linus Torvalds
Browse files

kasan: test: only do kmalloc_uaf_memset for generic mode 

kmalloc_uaf_memset() writes to freed memory, which is only safe with the
GENERIC mode (as it uses quarantine).  For other modes, this test corrupts
kernel memory, which might result in a crash.

Only enable kmalloc_uaf_memset() for the GENERIC mode.

Link: https://lkml.kernel.org/r/2e1c87b607b1292556cde3cab2764f108542b60c.1628779805.git.andreyknvl@gmail.com


Signed-off-by: default avatarAndrey Konovalov <andreyknvl@gmail.com>
Reviewed-by: default avatarMarco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1b0668be

lib/test_kasan.c

+6 −0
Original line number Diff line number Diff line
@@ -534,6 +534,12 @@ static void kmalloc_uaf_memset(struct kunit *test) 
	char *ptr;

	size_t size = 33;



	/*

	 * Only generic KASAN uses quarantine, which is required to avoid a

	 * kernel memory corruption this test causes.

	 */

	KASAN_TEST_NEEDS_CONFIG_ON(test, CONFIG_KASAN_GENERIC);



	ptr = kmalloc(size, GFP_KERNEL);

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr);