Commit 259b3633 authored by Hui Su's avatar Hui Su Committed by Linus Torvalds
Browse files

mm/oom_kill: change comment and rename is_dump_unreclaim_slabs() 

Change the comment of is_dump_unreclaim_slabs(), it just check whether
nr_unreclaimable slabs amount is greater than user memory, and explain why
we dump unreclaim slabs.

Rename it to should_dump_unreclaim_slab() maybe better.

Link: https://lkml.kernel.org/r/20201030182704.GA53949@rlk


Signed-off-by: default avatarHui Su <sh_def@163.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2271b016

mm/oom_kill.c

+8 −6
Original line number Diff line number Diff line
@@ -170,11 +170,13 @@ static bool oom_unkillable_task(struct task_struct *p) 
	return false;

}



/*

 * Print out unreclaimble slabs info when unreclaimable slabs amount is greater

 * than all user memory (LRU pages)

/**

 * Check whether unreclaimable slab amount is greater than

 * all user memory(LRU pages).

 * dump_unreclaimable_slab() could help in the case that

 * oom due to too much unreclaimable slab used by kernel.

*/

static bool is_dump_unreclaim_slabs(void)

static bool should_dump_unreclaim_slab(void)

{

	unsigned long nr_lru;
@@ -463,7 +465,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p) 
		mem_cgroup_print_oom_meminfo(oc->memcg);

	else {

		show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask);

		if (is_dump_unreclaim_slabs())

		if (should_dump_unreclaim_slab())

			dump_unreclaimable_slab();

	}

	if (sysctl_oom_dump_tasks)