Commit 25846fa1 authored by Yangtao Li's avatar Yangtao Li Committed by MyungJoo Ham
Browse files

PM / devfreq: fix missing check of return value in devfreq_add_device() 



devm_kzalloc() could fail, so insert a check of its return value. And
if it fails, returns -ENOMEM.

Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Signed-off-by: default avatarMyungJoo Ham <myungjoo.ham@samsung.com>
parent a9487917

drivers/devfreq/devfreq.c

+13 −1
Original line number Diff line number Diff line
@@ -689,10 +689,22 @@ struct devfreq *devfreq_add_device(struct device *dev, 
					 devfreq->profile->max_state,

					 devfreq->profile->max_state),

			     GFP_KERNEL);

	if (!devfreq->trans_table) {

		mutex_unlock(&devfreq->lock);

		err = -ENOMEM;

		goto err_devfreq;

	}



	devfreq->time_in_state = devm_kcalloc(&devfreq->dev,

						devfreq->profile->max_state,

						sizeof(unsigned long),

						GFP_KERNEL);

	if (!devfreq->time_in_state) {

		mutex_unlock(&devfreq->lock);

		err = -ENOMEM;

		goto err_devfreq;

	}



	devfreq->last_stat_updated = jiffies;



	srcu_init_notifier_head(&devfreq->transition_notifier_list);
@@ -726,7 +738,7 @@ struct devfreq *devfreq_add_device(struct device *dev, 


err_init:

	mutex_unlock(&devfreq_list_lock);



err_devfreq:

	devfreq_remove_device(devfreq);

	devfreq = NULL;

err_dev: