Unverified Commit 2554877e authored Oct 28, 2021 by Julian Braha Committed by Mark Brown Oct 29, 2021

ASoC: fix unmet dependencies on GPIOLIB for SND_SOC_RT1015P



When SND_SOC_MT8192_MT6359_RT1015_RT5682,
SND_SOC_MT8192_MT6359_RT1015_RT5682,
SND_SOC_MT8183_DA7219_MAX98357A, or
SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A is selected,
and GPIOLIB is not selected, Kbuild gives the following
warnings, respectively:

WARNING: unmet direct dependencies detected for SND_SOC_DMIC
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_MT8192_MT6359_RT1015_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8192 [=y] && MTK_PMIC_WRAP [=y]

WARNING: unmet direct dependencies detected for SND_SOC_RT1015P
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_MT8192_MT6359_RT1015_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8192 [=y] && MTK_PMIC_WRAP [=y]

WARNING: unmet direct dependencies detected for SND_SOC_RT1015P
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_MT8183_DA7219_MAX98357A [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_MT8183 [=y] && I2C [=y]

WARNING: unmet direct dependencies detected for SND_SOC_RT1015P
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8183 [=y]

This is because these config options select SND_SOC_RT1015P
without selecting or depending on GPIOLIB, despite
SND_SOC_RT1015P depending on GPIOLIB.

These unmet dependency bugs were detected by Kismet,
a static analysis tool for Kconfig. Please advise if this
is not the appropriate solution.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20211029001225.27218-1-julianbraha@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 986c5b0a

sound/soc/mediatek/Kconfig

+4 −4

Original line number	Diff line number	Diff line
		@@ -120,7 +120,7 @@ config SND_SOC_MT8183

		config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A
		tristate "ASoC Audio driver for MT8183 with MT6358 TS3A227E MAX98357A RT1015 codec"
		depends on I2C
		depends on I2C && GPIOLIB
		depends on SND_SOC_MT8183
		select SND_SOC_MT6358
		select SND_SOC_MAX98357A
		@@ -138,7 +138,7 @@ config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A

		config SND_SOC_MT8183_DA7219_MAX98357A
		tristate "ASoC Audio driver for MT8183 with DA7219 MAX98357A RT1015 codec"
		depends on SND_SOC_MT8183 && I2C
		depends on SND_SOC_MT8183 && I2C && GPIOLIB
		select SND_SOC_MT6358
		select SND_SOC_MAX98357A
		select SND_SOC_RT1015
		@@ -173,7 +173,7 @@ config SND_SOC_MT8192

		config SND_SOC_MT8192_MT6359_RT1015_RT5682
		tristate "ASoC Audio driver for MT8192 with MT6359 RT1015 RT5682 codec"
		depends on I2C
		depends on I2C && GPIOLIB
		depends on SND_SOC_MT8192 && MTK_PMIC_WRAP
		select SND_SOC_MT6359
		select SND_SOC_RT1015
		@@ -200,7 +200,7 @@ config SND_SOC_MT8195

		config SND_SOC_MT8195_MT6359_RT1019_RT5682
		tristate "ASoC Audio driver for MT8195 with MT6359 RT1019 RT5682 codec"
		depends on I2C
		depends on I2C && GPIOLIB
		depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
		select SND_SOC_MT6359
		select SND_SOC_RT1015P