Commit 2554322b authored by Alex Elder's avatar Alex Elder Committed by Paolo Abeni
Browse files

net: ipa: remove two memory region checks 



There's no need to ensure table memory regions fit within the
IPA-local memory range.  And there's no need to ensure the modem
header memory region is in range either.  These are verified for all
memory regions in ipa_mem_size_valid(), once we have settled on the
size of IPA memory.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent fb4014ac

drivers/net/ipa/ipa_cmd.c

+0 −19
Original line number Diff line number Diff line
@@ -197,16 +197,6 @@ bool ipa_cmd_table_valid(struct ipa *ipa, const struct ipa_mem *mem, bool route) 
		return false;

	}



	/* Entire memory range must fit within IPA-local memory */

	if (mem->offset > ipa->mem_size ||

	    mem->size > ipa->mem_size - mem->offset) {

		dev_err(dev, "%s table region out of range\n", table);

		dev_err(dev, "    (0x%04x + 0x%04x > 0x%04x)\n",

			mem->offset, mem->size, ipa->mem_size);



		return false;

	}



	return true;

}
@@ -257,15 +247,6 @@ static bool ipa_cmd_header_valid(struct ipa *ipa) 
		return false;

	}



	/* Make sure the entire combined area fits in IPA memory */

	if (size > ipa->mem_size || offset > ipa->mem_size - size) {

		dev_err(dev, "header table region out of range\n");

		dev_err(dev, "    (0x%04x + 0x%04x > 0x%04x)\n",

			offset, size, ipa->mem_size);



		return false;

	}



	return true;

}