Commit 24f8cb1e authored by Nanyong Sun's avatar Nanyong Sun Committed by Linus Torvalds
Browse files

nilfs2: fix memory leak in nilfs_sysfs_create_##name##_group 

If kobject_init_and_add return with error, kobject_put() is needed here to
avoid memory leak, because kobject_init_and_add may return error without
freeing the memory associated with the kobject it allocated.

Link: https://lkml.kernel.org/r/20210629022556.3985106-4-sunnanyong@huawei.com
Link: https://lkml.kernel.org/r/1625651306-10829-4-git-send-email-konishi.ryusuke@gmail.com


Signed-off-by: default avatarNanyong Sun <sunnanyong@huawei.com>
Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent dbc6e7d4

fs/nilfs2/sysfs.c

+2 −2
Original line number Diff line number Diff line
@@ -79,8 +79,8 @@ static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \ 
	err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \

				    #name); \

	if (err) \

		kobject_put(kobj); \

	return err; \

	return 0; \

} \

static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \

{ \