Commit 24d696a7 authored by Al Viro's avatar Al Viro
Browse files

cris: missing checks of __get_user()/__put_user() return values 



Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 43f16819

arch/cris/arch-v10/kernel/signal.c

+6 −6
Original line number Diff line number Diff line
@@ -65,10 +65,10 @@ int sys_sigaction(int sig, const struct old_sigaction __user *act, 
		old_sigset_t mask;

		if (!access_ok(VERIFY_READ, act, sizeof(*act)) ||

		    __get_user(new_ka.sa.sa_handler, &act->sa_handler) ||

		    __get_user(new_ka.sa.sa_restorer, &act->sa_restorer))

		    __get_user(new_ka.sa.sa_restorer, &act->sa_restorer) ||

		     __get_user(new_ka.sa.sa_flags, &act->sa_flags) ||

		     __get_user(mask, &act->sa_mask))

			return -EFAULT;

		__get_user(new_ka.sa.sa_flags, &act->sa_flags);

		__get_user(mask, &act->sa_mask);

		siginitset(&new_ka.sa.sa_mask, mask);

	}
@@ -77,10 +77,10 @@ int sys_sigaction(int sig, const struct old_sigaction __user *act, 
	if (!ret && oact) {

		if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)) ||

		    __put_user(old_ka.sa.sa_handler, &oact->sa_handler) ||

		    __put_user(old_ka.sa.sa_restorer, &oact->sa_restorer))

		    __put_user(old_ka.sa.sa_restorer, &oact->sa_restorer) ||

		    __put_user(old_ka.sa.sa_flags, &oact->sa_flags) ||

		    __put_user(old_ka.sa.sa_mask.sig[0], &oact->sa_mask))

			return -EFAULT;

		__put_user(old_ka.sa.sa_flags, &oact->sa_flags);

		__put_user(old_ka.sa.sa_mask.sig[0], &oact->sa_mask);

	}



	return ret;

arch/cris/arch-v32/kernel/signal.c

+6 −6
Original line number Diff line number Diff line
@@ -79,11 +79,11 @@ sys_sigaction(int signal, const struct old_sigaction *act, 


		if (!access_ok(VERIFY_READ, act, sizeof(*act)) ||

		    __get_user(newk.sa.sa_handler, &act->sa_handler) ||

		    __get_user(newk.sa.sa_restorer, &act->sa_restorer))

		    __get_user(newk.sa.sa_restorer, &act->sa_restorer) ||

		    __get_user(newk.sa.sa_flags, &act->sa_flags) ||

		    __get_user(mask, &act->sa_mask))

			return -EFAULT;



		__get_user(newk.sa.sa_flags, &act->sa_flags);

		__get_user(mask, &act->sa_mask);

		siginitset(&newk.sa.sa_mask, mask);

	}
@@ -92,11 +92,11 @@ sys_sigaction(int signal, const struct old_sigaction *act, 
	if (!retval && oact) {

		if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)) ||

		    __put_user(oldk.sa.sa_handler, &oact->sa_handler) ||

		    __put_user(oldk.sa.sa_restorer, &oact->sa_restorer))

		    __put_user(oldk.sa.sa_restorer, &oact->sa_restorer) ||

		    __put_user(oldk.sa.sa_flags, &oact->sa_flags) ||

		    __put_user(oldk.sa.sa_mask.sig[0], &oact->sa_mask))

			return -EFAULT;



		__put_user(oldk.sa.sa_flags, &oact->sa_flags);

		__put_user(oldk.sa.sa_mask.sig[0], &oact->sa_mask);

	}



	return retval;